Skip to content

Commit

Permalink
Fix logging of cached response
Browse files Browse the repository at this point in the history
Cached responses often (always ?) provide a length meaning they were
never logged as such.
  • Loading branch information
xavfernandez committed Nov 22, 2019
1 parent 3ff2513 commit 8ba3e17
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions src/pip/_internal/operations/prepare.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,16 +134,15 @@ def _prepare_download(
else:
url = link.url_without_fragment

redacted_url = redact_auth_from_url(url)
logged_url = redact_auth_from_url(url)

if total_length:
logger.info(
"Downloading %s (%s)", redacted_url, format_size(total_length)
)
elif is_from_cache(resp):
logger.info("Using cached %s", redacted_url)
logged_url = '{} ({})'.format(logged_url, format_size(total_length))

if is_from_cache(resp):
logger.info("Using cached %s", logged_url)
else:
logger.info("Downloading %s", redacted_url)
logger.info("Downloading %s", logged_url)

if logger.getEffectiveLevel() > logging.INFO:
show_progress = False
Expand Down

0 comments on commit 8ba3e17

Please sign in to comment.