-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiled source files are not identical across installations even when SOURCE_DATE_EPOCH is set to the same value #8414
Comments
triage-new-issues
bot
added
the
S: needs triage
Issues/PRs that need to be triaged
label
Jun 9, 2020
This is a duplicate of #7808. |
peteyan
pushed a commit
to peteyan/microstack
that referenced
this issue
Jan 7, 2021
Major changes: * Plumbing necessary for strict confinement with the microstack-support interface canonical/snapd#8926 * Until the interface is merged, devmode will be used and kernel modules will be loaded via an auxiliary service. * upgraded OpenStack components to Focal (20.04) and OpenStack Ussuri; * reworked the old patches; * added the Placement service since it is now separate; * addressed various build issues due to changes in snapcraft and built dependencies: * e.g. libvirt requires the build directory to be separate from the source directory) and LP: #1882255; * LP: #1882535 and pypa/pip#8414 * LP: #1882839 * LP: #1885294 * https://storyboard.openstack.org/#!/story/2007806 * LP: #1864589 * LP: #1777121 * LP: #1881590 * ML2/OVS replated with ML2/OVN; * dnsmasq is not used anymore; * neutron l3 and DHCP agents are not used anymore; * Linux network namespaces are only used for neutron-ovn-metadata-agent. * ML2 DNS support is done via native OVN mechanisms; * OVN-related database services (southbound and northbound dbs); * OVN-related control plane services (ovn-controller, ovn-northd); * core20 base support (bionic hosts are supported); * the removal procedure now relies on the "remove" hook since `snap remove` cannot be used from the confined environment anymore; * prerequisites to enabling AppArmor confinement for QEMU processes created by the confined libvirtd. * Added the Spice html5 console proxy service to enable clients to retrieve and use it via `microstack.openstack console url show --spice <servername>`. * Added missing Cinder templates and DB migrations for the Cinder DB. * Added experimental support for a loop device-based LVM backend for Cinder. Due to LP: #1892895 this is not recommended to be used in production except for tempest testing with an applied workaround; * includes iscsid and iscsi-tcp kernel module loading; * includes LIO and loading of relevant kernel modules; * An LVM PV is created on top of a loop device with a backing file present in $SNAP_COMMON/cinder-lvm.img; * A VG is created on top of the PV; * LVs are created by Cinder and exported via LIO over iscsi to iscsid which hot-plugs new SCSI devices. Those SCSI devices are then propagated by Nova to libvirt and QEMU during volume attachment; * Added post-deployment testing via rally and tempest (via the microstack-test snap). A set of tests included into Refstack 2018.02 is executed (except for object storage tests due to the lack of object storage support). Change-Id: Ic70770095860a57d5e0a55a8a9451f9db6be7448
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Environment
Description
.pyc
files generated during wheel installation include absolute paths of files unpacked to temporary directories such as'/tmp/pip-unpacked-wheel-79blnlyq/setuptools/command/bdist_egg.py
.Thus, even when
SOURCE_DATE_EPOCH
is set to the same value across different installations of the same package,.pyc
files are different.A distro bug with more details: https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1882535 starting with comment 2.
This happens because pip passes absolute paths for source files to py_compile which then uses
source_to_code
to get a code object that includes this absolute file path. py_compile then usesmarshal.dumps
on that code object to generate the final.pyc
file - as a result, the .pyc file content always includes bytes from the temporary path generated by pip => builds aren't reproducible even when the PycInvalidationMode is forced toCHECKED_HASH
viaSOURCE_DATE_EPOCH
.https://github.com/python/cpython/blob/0f5a28f834bdac2da8a04597dc0fc5b71e50da9d/Lib/py_compile.py#L144-L145
https://docs.python.org/3/library/importlib.html#importlib.abc.InspectLoader.source_to_code
Expected behavior
.pyc
files have the same hash across installations ifSOURCE_DATE_EPOCH
is the same.How to Reproduce
The text was updated successfully, but these errors were encountered: