Try to make distutils not emit relative paths #10257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
locations-relative-prefix
branch
from
725b75f to
7d5a65c
Compare
|
@mdmintz @msapiro Continuing the conversation in #10151, did you use the built-in It would also be awesome if you could provide the following outputs for me (from the problematic virtual environment): import sys
print(sys.prefix)
print(sys.base_prefix)
print(sys.real_prefix) |
uranusjr
force-pushed
the
locations-relative-prefix
branch
from
7d5a65c to
b4055ed
Compare
I have tried to duplicate this issue on two different servers including the one where I see the issue by creating new directories and virtualenvs that mimic the problem layout, but when I do this, I don't see the issue. When I mimic the activation and cd that my script does when I see the problem, I get When I then do without anything in between I get virtualenv --version gives me One other thing which is puzzling. The script that I run actually does the |
|
@uranusjr The virtual environment was created with Here's the And here's the latest info you wanted: |
|
Thanks for the additional information! I tried multiple virtualenv versions and was able to reproduce this with virtualenv 13.1.2 (likely earlier). I will still try to fix this warning, but recreating the virtual environment with a newer version of Another side note, the output when creating the environment is quite indicative: You can see how 13.1.2 creates a new python executable at a relative path, but 14.0.6 makes the path absolute. |
Our own override for the distutils implementation has a bug :)
virtualenv<14 does not normalize sys.prefix correctly, so we need to do it on our own.
uranusjr
force-pushed
the
locations-relative-prefix
branch
from
b4055ed to
a3b186a
Compare
pradyunsg
approved these changes
Aug 6, 2021
|
It’s mostly backward compatibility stuff (some variable/function used before is broken on old version of something so we need to do the same thing with another variable/function). So if you can’t understand the difference, it’s probably right 😆 |
Merged
|
I confirm that this fixes my issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10151 (comment)
#10151 (comment)
To prevent distutils from returning weird paths, try to normalise the target prefix before passing it into distutils.Not sure how well this would work, so not pinging people for testing yet…Turns out the original implementation simply had a bug… This should fix the relative path issue (but not the normalisation part).