Josev814 invocation for pip patch #11388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, when pip is installed in /usr/local/bin/pip, shutil.which detects this. The binary_prefix is defaulting to /usr/bin/. If the file isn't symlinked to /usr/bin it will error out. Adding in a check to verify that the (binary_prefix, exe_name) exists should be done before passing to samefile to prevent errors from being thrown and for the -m invocation to then be used.
Adding rst news file
fixing bin_path to bin_exe_path variable
|
Handled by pr #11318 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, when pip is installed in /usr/local/bin/pip, shutil.which detects this. The binary_prefix is defaulting to /usr/bin/. If the file isn't symlinked to /usr/bin it will error out. Adding in a check to verify that the (binary_prefix, exe_name) exists should be done before passing to samefile to prevent errors from being thrown and for the -m invocation to then be used.
Bug: #11387