-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade vendored dependencies #12518
Conversation
I don't think we should include the files being flagged in |
I have opened msgpack/msgpack-python#580 to enquire about this .cpp, .h and .pyx files that are now shipped in their wheels.
In the meantime I remove this commit. |
933cfcb
to
306597a
Compare
The last @pradyunsg does the vendoring process have a way to check python version compatibility? |
306597a
to
8e61819
Compare
Ditto for platformdirs. @pradyunsg another question, is it possible to specify an upper bound version for a package in vendoring process? So, now python 3.7 support starts to be annoying. I'm now inclined to drop it. |
+1 on dropping 3.7 support. |
8e61819
to
e9bb196
Compare
5f9da67
to
b968548
Compare
Oooh, not at the moment no. |
No, it does not. |
I also updated Regarding urllib3, is there a particular reason to not upgrade to 2.x, beyond the fact that updating our patch is difficult? |
IIRC, requests wasn't ready for the newer urllib3 at the time. We should probably look into upgrading to urllib3 unconditionally. |
I merged this so that we don't end up with a long tail of conflicts on here -- let's tackle urllib3 in a separate PR. :) |
The urllib3 2.0 issue was related to openssl support: #12026 (comment) |
Upgrade vendored dependencies early in the 24.1 release cycle.
Missing here is certify (the patch does not apply), and of course, packaging.
closes #12556