Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vendored dependencies #12518

Merged
merged 12 commits into from
Mar 10, 2024
Merged

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Feb 11, 2024

Upgrade vendored dependencies early in the 24.1 release cycle.

Missing here is certify (the patch does not apply), and of course, packaging.

closes #12556

@pfmoore
Copy link
Member

pfmoore commented Feb 11, 2024

I don't think we should include the files being flagged in msgpack - they look like they are related to a compiled extension. I'm assuming msgpack can still be used as pure Python?

@sbidoul sbidoul marked this pull request as draft February 12, 2024 07:10
@sbidoul
Copy link
Member Author

sbidoul commented Feb 17, 2024

I have opened msgpack/msgpack-python#580 to enquire about this .cpp, .h and .pyx files that are now shipped in their wheels.

msgpack otherwise still works in pure python mode.

In the meantime I remove this commit.

@sbidoul sbidoul force-pushed the upgrade-vendored-deps-sbi branch 2 times, most recently from 933cfcb to 306597a Compare February 17, 2024 12:38
@sbidoul
Copy link
Member Author

sbidoul commented Feb 17, 2024

The last typing-extension that supports python 3.7 is 4.7.1, removing that commit.

@pradyunsg does the vendoring process have a way to check python version compatibility?

@sbidoul sbidoul force-pushed the upgrade-vendored-deps-sbi branch from 306597a to 8e61819 Compare February 17, 2024 12:57
@sbidoul
Copy link
Member Author

sbidoul commented Feb 17, 2024

Ditto for platformdirs.

@pradyunsg another question, is it possible to specify an upper bound version for a package in vendoring process?

So, now python 3.7 support starts to be annoying. I'm now inclined to drop it.

@pfmoore
Copy link
Member

pfmoore commented Feb 17, 2024

+1 on dropping 3.7 support.

@sbidoul sbidoul force-pushed the upgrade-vendored-deps-sbi branch from 8e61819 to e9bb196 Compare February 18, 2024 17:28
@sbidoul sbidoul marked this pull request as ready for review February 18, 2024 17:43
@sbidoul sbidoul force-pushed the upgrade-vendored-deps-sbi branch from 5f9da67 to b968548 Compare March 10, 2024 10:43
@pradyunsg
Copy link
Member

@pradyunsg another question, is it possible to specify an upper bound version for a package in vendoring process?

Oooh, not at the moment no.

@pradyunsg
Copy link
Member

@pradyunsg does the vendoring process have a way to check python version compatibility?

No, it does not.

@sbidoul
Copy link
Member Author

sbidoul commented Mar 10, 2024

I also updated msgpack (which has a release without the .cpp and .h files), certifi (I updated the patch) and urliib3<2.

Regarding urllib3, is there a particular reason to not upgrade to 2.x, beyond the fact that updating our patch is difficult?

@pradyunsg
Copy link
Member

Regarding urllib3, is there a particular reason to not upgrade to 2.x,

IIRC, requests wasn't ready for the newer urllib3 at the time. We should probably look into upgrading to urllib3 unconditionally.

@pradyunsg pradyunsg merged commit fb5f63f into pypa:main Mar 10, 2024
24 checks passed
@pradyunsg
Copy link
Member

I merged this so that we don't end up with a long tail of conflicts on here -- let's tackle urllib3 in a separate PR. :)

@notatallshaw
Copy link
Member

The urllib3 2.0 issue was related to openssl support: #12026 (comment)

@sbidoul sbidoul deleted the upgrade-vendored-deps-sbi branch March 10, 2024 15:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update urllib3 to 1.26.18 or above
4 participants