Use --no-build-isolation in tests to avoid using Internet
#12787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
added
C: tests
sbidoul
approved these changes
Jun 23, 2024
ichard26
approved these changes
Jun 23, 2024
|
Main CI is green now. Let's merge main in here and get this landed. |
Add `--no-build-isolation` to the pip invocation in `pip_editable_parts` fixture and a few tests, to avoid downloading `setuptools` wheel from PyPI. This change makes it possible again to run the vast majority of pip tests (with the exception of 3 tests) offline. Fixes pypa#12786.
|
Thanks! |
pradyunsg
pushed a commit
to pradyunsg/pip
that referenced
this pull request
Jul 7, 2024
Use `--no-build-isolation` in tests to avoid using Internet
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--no-build-isolationto the pip invocation inpip_editable_partsfixture and a few tests, to avoid downloadingsetuptoolswheel from PyPI. This change makes it possible again to run the vast majority of pip tests (with the exception of 3 tests) offline.Fixes #12786.
[I don't think this is an end user-facing change, so no news item]