Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-project.py compatibility note #13177

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jan 26, 2025

Our build script uses venv.create(), which is broken in some cases when using python-build-standalone distributions.

Adding a comment mentioning this to avoid future head scratching.

astral-sh/python-build-standalone#381

@sbidoul sbidoul added this to the 25.1 milestone Jan 26, 2025
@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 26, 2025
@sbidoul sbidoul modified the milestones: 25.1, 25.0 Jan 26, 2025
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script also blows up with my user Python install, although that could just be me not knowing how to properly build and install CPython from source :P

$ python -m venv
Error: Command '['/home/ichard26/dev/oss/pip/test/bin/python', '-m', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1.

I do have a workaround, already.

@sbidoul sbidoul merged commit 0d609f7 into pypa:main Jan 26, 2025
11 checks passed
@sbidoul sbidoul deleted the add-build-project-note branch January 26, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants