Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PEP 508 @ url syntax #4175

Merged
merged 3 commits into from
Feb 5, 2017
Merged

Add support for PEP 508 @ url syntax #4175

merged 3 commits into from
Feb 5, 2017

Conversation

xavfernandez
Copy link
Member

@xavfernandez xavfernandez commented Dec 11, 2016 •
edited by pradyunsg
Loading

No description provided.

@dstufft
Copy link
Member

dstufft commented Dec 11, 2016

Is this in install_requires? Because we should not support it there yet, until PyPI is blocking uploads that use it.

@xavfernandez
Copy link
Member Author

@dstufft it should also work with install_requires (added a small test to check).

until PyPI is blocking uploads that use it.

But how do you plan to block such upload on PyPI ?
With wheel, it could be easy, but with sdist, I don't really see a way...

@dstufft
Copy link
Member

dstufft commented Dec 11, 2016

@xavfernandez Undetermined yet. It will likely be resolved as part of future PEPs that let PyPI get more introspection into sdists. Until then though, random sdists should not be allowed to reach out to random URLs willy nilly.

@dstufft
Copy link
Member

dstufft commented Dec 11, 2016

To be clear, I'm totally fine with having this work on the command line and in a requirements.txt file. It just should not work from within a sdist or a wheel file at all until PyPI can assure people aren't going to suddenly start reaching out to random hosts unexpectedly. A lot of work and time has gone into getting rid of the cases where that used to happen, and I am very much against adding back in a new feature that re-introduces it.

@xavfernandez
Copy link
Member Author

To be clear, I'm totally fine with having this work on the command line and in a requirements.txt file.

Last commit should only block the subrequirement case.

@xavfernandez
Copy link
Member Author

@dstufft Is this implementation (with the subreq limitation) ok to you ?

@xavfernandez xavfernandez force-pushed the improve_pep508_support branch from 2b6081a to 007b31e Compare December 26, 2016 12:53
@xavfernandez
Copy link
Member Author

ping @dstufft to merge this :)

@xavfernandez xavfernandez added this to the 9.1 milestone Jan 6, 2017
@xavfernandez xavfernandez force-pushed the improve_pep508_support branch from 007b31e to 0e3c44d Compare January 6, 2017 22:37
@xavfernandez xavfernandez force-pushed the improve_pep508_support branch from 0e3c44d to 4717b78 Compare January 18, 2017 09:31
@xavfernandez xavfernandez force-pushed the improve_pep508_support branch from 4717b78 to 86b0779 Compare January 30, 2017 09:22
@xavfernandez xavfernandez merged commit 6ec5597 into pypa:master Feb 5, 2017
@xavfernandez xavfernandez deleted the improve_pep508_support branch February 5, 2017 11:22
@di di mentioned this pull request Apr 15, 2017
Closed
@pradyunsg pradyunsg mentioned this pull request Oct 2, 2017
Closed
@pradyunsg pradyunsg mentioned this pull request Nov 5, 2017
Closed
@pamolloy pamolloy mentioned this pull request Jan 11, 2018
Closed
@gsarma gsarma mentioned this pull request Apr 25, 2018
Open
pbugnion referenced this pull request in facultyai/faculty-sync May 9, 2018
Use dependency_links to install prompt_toolkit 2.0
17976a0 
To avoid having to install using a bash script, we can specify a version of prompt_toolkit and provide the github branch tarball for 2.0 as a dependency link.

This means when installing with pip install sml-sync --process-dependency-links, pip will install prompt toolkit from the github repo.

This means we can close the bitbucket repo.
@sjperkins sjperkins mentioned this pull request Nov 19, 2018
Open
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xavfernandez @dstufft