Fix the pip version check when using --no-cache-dir #5680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segevfiner
force-pushed
the
no-cache-dir-version-check
branch
from
6590ee9 to
6a86be9
Compare
segevfiner
force-pushed
the
no-cache-dir-version-check
branch
from
6a86be9 to
15a810e
Compare
|
Could this patch please be merged? It fixes two of the three tracebacks reported in #5679 I wasn't able to reproduce #5679 (comment) . @segevfiner could you share how to reproduce that from scratch? |
|
|
Thanks for the PR @segevfiner! I didn't notice this until after I'd made a similar PR. #5764 should have fixed all the relevant tracebacks. :) Would you be willing to help out by working on a different issue? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pip version check will now work correctly when using
--no-cache-dir.Fixes #5679