Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow logging errors during tests even if allow_stderr_error=True #6474

Merged
merged 3 commits into from
May 10, 2019

Conversation

cjerdonek
Copy link
Member

This is a follow-on to PR #6383 by addressing this follow-up task mentioned in the PR's original comment:

Possible future change / improvement: also check for logging errors when our tests are running even if allow_stderr_error is true.

cjerdonek added 3 commits May 7, 2019 06:51
We do this to better parallel the test order in TestPipTestEnvironment,
since the tests using run_with_log_command() occur later.
@cjerdonek cjerdonek added C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) labels May 7, 2019
@cjerdonek cjerdonek merged commit 53c5293 into pypa:master May 10, 2019
@cjerdonek cjerdonek deleted the logging-errors-during-tests branch May 10, 2019 15:13
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant