Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a disclaimer to the "Installation Order" section #6604

Merged
merged 1 commit into from
Jun 16, 2019

Conversation

pradyunsg
Copy link
Member

This section has caused a lot of user confusion since PEP 517/518. It seems that users are referring to this section for advice about how to deal with build time issues, which contains statements that do not hold true for build requirements.

This section has caused a lot of user confusion since PEP 517/518. It seems that users are referring to this section for advice about how to deal with build time issues, which contains statements that do not hold true for build requirements.
@pradyunsg pradyunsg added type: docs Documentation related skip news Does not need a NEWS file entry (eg: trivial changes) labels Jun 13, 2019
Copy link
Member

@cjerdonek cjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe “is only about” to be less informal-sounding and “and does not apply” to read more concisely as one sentence.

@pradyunsg
Copy link
Member Author

Merging this right now. :)

@cjerdonek I'm on board for that -- let's have a good-first-issue for it or do that in a follow up PR?

@pradyunsg pradyunsg merged commit 61c4b61 into master Jun 16, 2019
@pradyunsg pradyunsg deleted the pradyunsg-install-order-disclaimer branch June 16, 2019 12:13
@pradyunsg
Copy link
Member Author

Follow up at #6619.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jul 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants