Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SafeFileCache to network.cache #7062

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Move SafeFileCache to network.cache #7062

merged 1 commit into from
Sep 25, 2019

Conversation

chrahunt
Copy link
Member

No description provided.

@chrahunt chrahunt added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Sep 21, 2019
@chrahunt chrahunt changed the title Move SafeFileCache to network.cache. Move SafeFileCache to network.cache Sep 21, 2019
@chrahunt chrahunt marked this pull request as ready for review September 21, 2019 22:52
pradyunsg
pradyunsg reviewed Sep 22, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to move it into your pip._internal.cache?

@chrahunt
Copy link
Member Author

I think it belongs in network because it is specifically a cachecontrol.cache.BaseCache, to be used with requests.

@chrahunt
Copy link
Member Author

In case we need more justification - keeping it out of cache allows us to avoid a transitive import dependency on requests/urllib3.

@pradyunsg
Copy link
Member

Makes sense. :)

@chrahunt chrahunt merged commit 9611394 into pypa:master Sep 25, 2019
@chrahunt chrahunt deleted the refactor/network-modules branch September 25, 2019 01:03
This was referenced Sep 26, 2019
Merged
Closed
Closed
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrahunt @pradyunsg