Add per-file disallow_untyped_defs=False, and set it to True globally

noxfile.py

@@ -1,6 +1,9 @@
 """Release time helpers, executed using nox.
 """
 
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import io
 import subprocess
 

setup.cfg

@@ -29,6 +29,7 @@ ignore = W504
 [mypy]
 follow_imports = silent
 ignore_missing_imports = True
+disallow_untyped_defs = True
 
 [mypy-pip/_vendor/*]
 follow_imports = skip

setup.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import codecs
 import os
 import re

src/pip/_internal/build_env.py

@@ -3,6 +3,7 @@
 
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 import logging
 import os

src/pip/_internal/cli/autocompletion.py

@@ -1,6 +1,9 @@
 """Logic that powers autocompletion installed by ``pip completion``.
 """
 
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import optparse
 import os
 import sys

src/pip/_internal/cli/cmdoptions.py

@@ -9,6 +9,7 @@
 
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 from __future__ import absolute_import
 

src/pip/_internal/cli/command_context.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from contextlib import contextmanager
 
 from pip._vendor.contextlib2 import ExitStack

src/pip/_internal/cli/parser.py

@@ -1,4 +1,8 @@
 """Base option parser setup"""
+
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import logging

src/pip/_internal/cli/req_command.py

@@ -5,6 +5,9 @@
 PackageFinder machinery and all its vendored dependencies, etc.
 """
 
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import os
 from functools import partial
 

src/pip/_internal/collector.py

@@ -2,6 +2,9 @@
 The main purpose of this module is to expose LinkCollector.collect_links().
 """
 
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import cgi
 import itertools
 import logging

src/pip/_internal/commands/__init__.py

@@ -1,6 +1,10 @@
 """
 Package containing all pip commands
 """
+
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import importlib

src/pip/_internal/commands/check.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import logging
 
 from pip._internal.cli.base_command import Command

src/pip/_internal/commands/completion.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import sys

src/pip/_internal/commands/configuration.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import logging
 import os
 import subprocess

src/pip/_internal/commands/debug.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import locale

src/pip/_internal/commands/download.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import logging

src/pip/_internal/commands/freeze.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import sys

src/pip/_internal/commands/hash.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import hashlib

src/pip/_internal/commands/help.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 from pip._internal.cli.base_command import Command

src/pip/_internal/commands/install.py

@@ -4,6 +4,7 @@
 # couple errors where we have to know req.name is str rather than
 # Optional[str] for the InstallRequirement req.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 from __future__ import absolute_import
 

src/pip/_internal/commands/list.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import json

src/pip/_internal/commands/search.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import logging

src/pip/_internal/commands/show.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import logging

src/pip/_internal/commands/uninstall.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 from pip._vendor.packaging.utils import canonicalize_name

src/pip/_internal/commands/wheel.py

@@ -1,4 +1,8 @@
 # -*- coding: utf-8 -*-
+
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import logging

src/pip/_internal/configuration.py

@@ -13,6 +13,7 @@
 
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 import locale
 import logging

src/pip/_internal/distributions/base.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import abc
 
 from pip._vendor.six import add_metaclass

src/pip/_internal/distributions/installed.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from pip._internal.distributions.base import AbstractDistribution
 
 

src/pip/_internal/distributions/source/legacy.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import logging
 
 from pip._internal.build_env import BuildEnvironment

src/pip/_internal/distributions/wheel.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from pip._vendor import pkg_resources
 
 from pip._internal.distributions.base import AbstractDistribution

src/pip/_internal/download.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import cgi

src/pip/_internal/exceptions.py

@@ -1,4 +1,8 @@
 """Exceptions used throughout package"""
+
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 from itertools import chain, groupby, repeat

src/pip/_internal/index.py

@@ -2,6 +2,7 @@
 
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 from __future__ import absolute_import
 

src/pip/_internal/legacy_resolve.py

@@ -12,6 +12,7 @@
 
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 import logging
 import sys

src/pip/_internal/locations.py

@@ -2,6 +2,7 @@
 
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 from __future__ import absolute_import
 

src/pip/_internal/main.py

@@ -1,5 +1,8 @@
 """Primary application entrypoint.
 """
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import locale

src/pip/_internal/models/candidate.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from pip._vendor.packaging.version import parse as parse_version
 
 from pip._internal.utils.models import KeyBasedCompareMixin

src/pip/_internal/models/format_control.py

@@ -1,5 +1,6 @@
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 from pip._vendor.packaging.utils import canonicalize_name
 

src/pip/_internal/models/link.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import os
 import posixpath
 import re

src/pip/_internal/models/search_scope.py

@@ -1,3 +1,6 @@
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import itertools
 import logging
 import os

src/pip/_internal/network/auth.py

@@ -4,6 +4,9 @@
 providing credentials in the context of network requests.
 """
 
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import logging
 
 from pip._vendor.requests.auth import AuthBase, HTTPBasicAuth

src/pip/_internal/network/cache.py

@@ -1,5 +1,9 @@
 """HTTP cache implementation.
 """
+
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import os
 from contextlib import contextmanager
 

src/pip/_internal/network/session.py

@@ -1,6 +1,10 @@
 """PipSession and supporting code, containing all pip-specific
 network request configuration and behavior.
 """
+
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 import email.utils
 import json
 import logging

src/pip/_internal/operations/check.py

@@ -3,6 +3,7 @@
 
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 import logging
 from collections import namedtuple

src/pip/_internal/operations/freeze.py

@@ -1,5 +1,6 @@
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 from __future__ import absolute_import
 

src/pip/_internal/operations/prepare.py

@@ -3,6 +3,7 @@
 
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 import logging
 import os

src/pip/_internal/req/constructors.py

@@ -10,6 +10,7 @@
 
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 import logging
 import os

src/pip/_internal/req/req_install.py

@@ -1,5 +1,6 @@
 # The following comment should be removed at some point in the future.
 # mypy: strict-optional=False
+# mypy: disallow-untyped-defs=False
 
 from __future__ import absolute_import
 

src/pip/_internal/utils/appdirs.py

@@ -2,6 +2,10 @@
 This code was taken from https://github.com/ActiveState/appdirs and modified
 to suit our purposes.
 """
+
+# The following comment should be removed at some point in the future.
+# mypy: disallow-untyped-defs=False
+
 from __future__ import absolute_import
 
 import os