-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest a way of cleaning dist if non-empty #7665
Suggest a way of cleaning dist if non-empty #7665
Conversation
c60f588
to
fb2598a
Compare
Rebased on master to fix CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issues with this merging if someone else in @pypa/pip-helpers or @pypa/pip-committers think this is useful, but I don't think I'd be merging this in myself.
As worded, the new suggestion seems to nudge toward deleting dist/ without taking a look. It's easy enough to automate the deleting of an unnecessary directory but I'd figured that we should not be deleting dist/ by default here. That's because I prefer automation that avoids destructive actions in situations where it's not known what the cause for the fault is or what the correct corrective action should be (do they care about what's in dist/? should they? how can we know? can the action be undone?).
OTOH, I'm sure that someone making a pip release would know what to do to delete a folder, so providing a suggestion isn't required. Plus, some part of me looks at the git command here and it is not clear what it does or why this is the correct suggestion. FWIW, it is the only cross platform suggestion that I could think of too.
@pradyunsg that's why I added |
Also that's why it says "you can", not "you must" |
Ah well. The interactive bit does sound useful -- I just tried it locally and, yea, makes sense. Me likey this now. |
This is extracted from #7654.