Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the usage of --no-binary command #7931

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Clarify the usage of --no-binary command #7931

merged 1 commit into from
Mar 30, 2020

Conversation

cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Mar 29, 2020

Fixes #3191
Emphasize the existence of colons and add two examples.

@cjc7373 cjc7373 force-pushed the update_doc_about_no_binary branch from 97372eb to 4e28210 Compare March 29, 2020 11:19
cjc7373
cjc7373 commented Mar 29, 2020
View reviewed changes
src/pip/_internal/cli/cmdoptions.py Outdated
"(notice the colons), or one or more package names with commas "
"between them (no colons). Note that some packages are tricky to "
"compile and may fail to install when this option is used on "
"them.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reordered the words to resolve the "E501 line too long" lint error, so the change seems a bit weird here...

@McSinyx
Copy link
Contributor

McSinyx commented Mar 30, 2020

Can we please single quote the string to avoid escaping?

@cjc7373
Copy link
Contributor Author

cjc7373 commented Mar 30, 2020

@McSinyx I saw most of the quotes in doc are double quotes, maybe we should keep the consistency?

@uranusjr
Copy link
Member

The preference is to use double quotes to avoid needing to escape common strings like it's, but in this case single quotes are better (since we don’t have single quotes in the string anyway).

@cjc7373
Copy link
Contributor Author

cjc7373 commented Mar 30, 2020

Got it! I'll push a new version.

@cjc7373 cjc7373 force-pushed the update_doc_about_no_binary branch from c8d07e4 to f7837b1 Compare March 30, 2020 09:18
@uranusjr
Copy link
Member

@cjc7373 Sorry my wording was unclear 😓 I meant using single quotes for the help string, like: 'Accepts either ":all:" to all binary packages, ":none:" to [...]'

@cjc7373
Copy link
Contributor Author

cjc7373 commented Mar 30, 2020

Yeah I've misunderstood your meaning. 🤣 Thanks for pointing out!

@cjc7373 cjc7373 force-pushed the update_doc_about_no_binary branch from f7837b1 to a51f7ba Compare March 30, 2020 11:36
@xavfernandez xavfernandez merged commit c388315 into pypa:master Mar 30, 2020
@xavfernandez
Copy link
Member

Thanks @cjc7373 :)

@cjc7373 cjc7373 deleted the update_doc_about_no_binary branch March 31, 2020 13:11
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@chrahunt chrahunt chrahunt approved these changes

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-binary / no-use-wheel mismatch
6 participants
@cjc7373 @McSinyx @uranusjr @xavfernandez @chrahunt @pradyunsg