Switch to sphinx-inline-tabs for tabs

[pradyunsg]

Follow up to #8589, to give us significantly better looking tabs.

[pradyunsg]

/cc @pfmoore @shireenrao :)

[pradyunsg]

https://sphinx-inline-tabs.readthedocs.io/en/latest/index.html -- in case you're looking for the docs.

[shireenrao]

These look great!!

[pfmoore]

The preview at https://pip--9008.org.readthedocs.build/en/9008/installing/ seems to be broken...

[shireenrao]

Sorry I was commenting on the examples on the readthedocs page..

[pradyunsg]

Interesting. It works locally, but not on the RTD page -- but only on the installation thingie.

[pradyunsg]

python /home/docs/checkouts/readthedocs.org/user_builds/pip/envs/9008/bin/sphinx-build -T -E -b readthedocsdirhtml -d _build/doctrees -D language=en . _build/html

Of course readthedocs uses it's own custom HTML builder called readthedocsdirhtml. >.<

[pfmoore]

So does that imply we need to request some change from RTD before this could be merged?

[pradyunsg]

So does that imply we need to request some change from RTD before this could be merged?

Nah -- pradyunsg/sphinx-inline-tabs@ace2f95 is sufficient. I'll wait for a few minutes before a close-reopen here.

[pradyunsg]

Cool yea, that worked.

[pfmoore]

(Offtopic) Just while I think, would this also be something to consider if we wanted to start using MyST?

[pradyunsg]

Just while I think, would this also be something to consider if we wanted to start using MyST?

As in?

It'll work the same way -- see https://github.com/pradyunsg/sphinx-inline-tabs/blame/main/docs/usage.md for how the MyST vs reST syntax is different. They both work the same way, and invoke the exact same code and whatnot.

[pfmoore]

Sorry, drive by comments while I'm doing something else. As in, does the MyST parser need to have explicit support for the RTD builders, and if so we should check that it does.

[pradyunsg]

As in, does the MyST parser need to have explicit support for the RTD builders, and if so we should check that it does.

Ah, no. They're affecting separate components.

The "builder" is the bit that decides where to put the generated HTML files. Those HTML files are provided by rendering the "theme" using the "parsed content". MyST generates the parsed content, and hence is a drop-in replacement, without needing support in any other part of the pipeline.

FWIW, the documentation I've linked to is MyST based and is on RTD without issues. :)

[pradyunsg]

I'mma click merge on this now -- since no one has raised concerns against doing this, and I genuinely think this looks much better. :)

Also, the longer this stays open, the greater the chances of conflicts and I dealt w/ enough of those for 20.2.4. Reverts are cheap too.

[shireenrao]

The pip docs look really good!

[pradyunsg]

@shireenrao IDK if you've seen #9012 -- you might be interested in that. ;)

[shireenrao]

Woah!! Thats super clean! Kudos on making such a sleek looking theme!