Merge pull request #2883 from Jamim/fix/get-virtualenv-hash

Fix _get_virtualenv_hash function
pypa · Nov 3, 2018 · 8799431 · 8799431
2 parents 785f2be + 780e879
commit 8799431
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -8,6 +8,9 @@
 .AppleDouble
 .LSOverride
 
+# PyCharm
+.idea/
+
 # VSCode
 .vscode
 

diff --git a/news/3151.bugfix b/news/3151.bugfix
@@ -0,0 +1 @@
+Fix project path hashing logic in purpose to prevent collisions of virtual environments.
diff --git a/pipenv/project.py b/pipenv/project.py
@@ -449,7 +449,7 @@ def get_name(name, location):
         #   In-project venv
         #   "Proper" path casing (on non-case-sensitive filesystems).
         if (
-            fnmatch.fnmatch("A", "a")
+            not fnmatch.fnmatch("A", "a")
             or self.is_venv_in_project()
             or get_workon_home().joinpath(venv_name).exists()
         ):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix project path hashing logic in purpose to prevent collisions of virtual environments.