Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace package pipfile with plette #5310

Closed
oz123 opened this issue Aug 30, 2022 · 1 comment · Fixed by #5339
Closed

Replace package pipfile with plette #5310

oz123 opened this issue Aug 30, 2022 · 1 comment · Fixed by #5339
Assignees
@oz123
Labels
Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.

Comments

@oz123
Copy link
Contributor

oz123 commented Aug 30, 2022

plette has all the abilities of pipfile and more.
The API is identical.
Also, pipfile isn't really maintained anymore. Hence, we should drop it, and use plette instead.
@oz123 oz123 self-assigned this Aug 30, 2022
@matteius matteius added the Type: Vendored Dependencies This issue affects vendored dependencies within pipenv. label Sep 2, 2022
@oz123
Copy link
Contributor Author

oz123 commented Sep 6, 2022

When we complete this, we can also close #5187.

@oz123 oz123 mentioned this issue Sep 8, 2022
Merged
@jeffwidman jeffwidman mentioned this issue Aug 5, 2023
Closed
jeffwidman added a commit to dependabot/dependabot-core that referenced this issue Aug 10, 2023
@jeffwidman
Switch from pipfile to plette lib
08a9369 
The main user of `pipfile` is `pipenv`, and _not_ any of the other
python package managers.

However, `pipfile` library has been pretty much unmaintained, so
`pipenv` switched to using `plette` for parsing/validation of
`Pipfile`'s:
* pypa/pipenv#5310
* pypa/pipenv#5339

So let's switch our usage as well. Today we only use `pipfile` for
generating hashes, so this is effectively a silent no-op. However, down
the road we could leverage `plette` for `Pipfile` parsing/validation...
for example see how it's flagging things here:
#6104 (comment)
jeffwidman added a commit to dependabot/dependabot-core that referenced this issue Aug 23, 2023
@jeffwidman
Switch from pipfile to plette lib
a4a8f75 
The main user of `pipfile` is `pipenv`, and _not_ any of the other
python package managers.

However, `pipfile` library has been pretty much unmaintained, so
`pipenv` switched to using `plette` for parsing/validation of
`Pipfile`'s:
* pypa/pipenv#5310
* pypa/pipenv#5339

So let's switch our usage as well. Today we only use `pipfile` for
generating hashes, so this is effectively a silent no-op. However, down
the road we could leverage `plette` for `Pipfile` parsing/validation...
for example see how it's flagging things here:
#6104 (comment)
@jeffwidman jeffwidman mentioned this issue Dec 16, 2023
Merged
jeffwidman added a commit to jeffwidman/dependabot-core that referenced this issue Mar 21, 2024
@jeffwidman
Switch from pipfile to plette lib
5ab89f4 
The main user of `pipfile` is `pipenv`, and _not_ any of the other
python package managers.

However, `pipfile` library has been pretty much unmaintained, so
`pipenv` switched to using `plette` for parsing/validation of
`Pipfile`'s:
* pypa/pipenv#5310
* pypa/pipenv#5339

So let's switch our usage as well. Today we only use `pipfile` for
generating hashes, so this is effectively a silent no-op. However, down
the road we could leverage `plette` for `Pipfile` parsing/validation...
for example see how it's flagging things here:
dependabot#6104 (comment)
abdulapopoola added a commit to dependabot/dependabot-core that referenced this issue Mar 22, 2024
@jeffwidman @abdulapopoola
Switch from pipfile to plette lib (#8627)
384ce3b 
The main user of `pipfile` is `pipenv`, and _not_ any of the other
python package managers.

However, `pipfile` library has been pretty much unmaintained, so
`pipenv` switched to using `plette` for parsing/validation of
`Pipfile`'s:
* pypa/pipenv#5310
* pypa/pipenv#5339

So let's switch our usage as well. Today we only use `pipfile` for
generating hashes, so this is effectively a silent no-op. However, down
the road we could leverage `plette` for `Pipfile` parsing/validation...
for example see how it's flagging things here:
#6104 (comment)

Co-authored-by: AbdulFattaah Popoola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oz123 oz123

Labels
Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace usage of pipfile pypa/pipenv
2 participants
@matteius @oz123