Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --extra-index-url for resolution #1706

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

kennethreitz
Copy link
Contributor

- Fixes #1539
- Currently writes the wrong index name to the lockfile
- Currently fails one round before succeeding
@kennethreitz kennethreitz merged commit 94db69a into master Mar 13, 2018
@techalchemy techalchemy deleted the feature/extra-index-url-sources branch April 11, 2018 01:45
@jonlil
Copy link

jonlil commented Apr 11, 2018

I think this caused issues with pipenv install --skip-lock

See this output

pipenv install --verbose --skip-lock                                                                                                                                                         1 ↵
Installing dependencies from Pipfile…
Installing 'uwsgi==2.0.17 --extra-index-url https://private.example.com/simple'

WARNING: Invalid requirement, parse error at "'--extra-'"
ABORTING INSTALL... You will have to reinstall any packages that failed to install.
You may have to manually run pipenv lock when you are finished.

Without knowing your implementation, I guess the problem is how you pass the arguments to pip.

["pip", "install", "--extra-index-url", "https://private.example.com/simple", "uwsgi==2.0.17"]

@techalchemy
Copy link
Member

@jonlil this is a pull request, not an issue

if you have a bug, please report it in a new issue

Without knowing your implementation, I guess the problem is how you pass the arguments to pip.

This is wrong, you are using this incorrectly, please read the documentation.

@jonlil
Copy link

jonlil commented Apr 11, 2018

I'm impressed that you know how I'm using it!

I'm aware that this is a PR, thought It should be more helpful to comment on the actual changes then on some random issue needing. Feel free to investigate on your own. I will not!

@techalchemy
Copy link
Member

techalchemy commented Apr 11, 2018

@jonlil edit this looks like an actual bug now that I reread, can you open an issue

@techalchemy
Copy link
Member

also apologies for the assumptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants