Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable installation using -i indexname #1950

Closed
wants to merge 1 commit into from

Conversation

techalchemy
Copy link
Member

Signed-off-by: Dan Ryan [email protected]

- Recognizes index names in pipfile
- Falls back to assuming index is a url and uses it as such
- Actually uses the index when passed at `pipenv install`
- Fixes #1852

Signed-off-by: Dan Ryan <[email protected]>
@uranusjr
Copy link
Member

Can’t this be handled with a click.option?

@techalchemy
Copy link
Member Author

@uranusjr I did consider that, but given the way we pass indexes around I didn't think so. This implementation feels bad though, I agree.

Ignoring the aliasing bit (taking index names and passing them through) we also don't currently take -i <index_url> from the command line either. I also noticed that if you pass an index, we are expecting all dependencies to be from the same index currently. A bunch of things here are kind of messed up and I didn't have the energy to pursue it further

@techalchemy techalchemy added help wanted Status: Needs More Information This issue does not provide enough information to take further action. Type: Discussion This issue is open for discussion. Type: Regression This issue is a regression of a previous behavior. labels Apr 11, 2018
@techalchemy techalchemy deleted the feature/1852-install-index-by-name branch April 20, 2018 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Status: Needs More Information This issue does not provide enough information to take further action. Type: Discussion This issue is open for discussion. Type: Regression This issue is a regression of a previous behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants