-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2527: Add ability to suppress nested venv courtesy notice #2581
Closed
Closed
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a4ede26
Add ability to suppress nested venv courtesy notice
Haplo-Dragon 4c070dc
Merge branch 'master' into fix#2527
Haplo-Dragon 7a50632
Add verbosity int variable, use capsys in test_core
Haplo-Dragon cd525d2
Move PIPENV_VERBOSITY to correct place in alphabet
Haplo-Dragon 41b8688
Merge branch 'master' into fix#2527
Haplo-Dragon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import io | ||
|
||
import pytest | ||
import mock | ||
from contextlib import redirect_stderr | ||
|
||
from pipenv.core import warn_in_virtualenv | ||
|
||
|
||
@mock.patch('pipenv.environments.PIPENV_VIRTUALENV', 'totallyrealenv') | ||
@mock.patch('pipenv.environments.PIPENV_SUPPRESS_NESTED_WARNING', '1') | ||
@pytest.mark.core | ||
def test_suppress_nested_venv_warning(): | ||
f = io.StringIO() | ||
# Capture the stderr of warn_in_virtualenv to test for the presence of the | ||
# courtesy notice. | ||
with redirect_stderr(f): | ||
warn_in_virtualenv() | ||
output = f.getvalue() | ||
assert 'Courtesy Notice' not in output | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d recommend using capsys to redirect stdout/stderr here. I didn’t test myself, and cannot access Buildkite logs either, but suspect this caused the build failure on Python 2.