Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass self when calling base class constructor. #3314

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

vthirumale
Copy link
Contributor

The issue

There is a bug, self missing self when calling base class constructor.

What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.

   File "/usr/local/lib/python2.7/site-packages/pipenv/exceptions.py", line 168, in __init__
     PipenvUsageError.__init__(message=fix_utf8(message), extra=extra, **kwargs)
  TypeError: unbound method __init__() must be called with PipenvUsageError instance as first argument (got nothing instead)

The fix

How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?

Pass in self as the first argument.

@techalchemy
Copy link
Member

Yep that is a bug! thanks for the fix!

@techalchemy techalchemy merged commit 20efdef into pypa:master Nov 27, 2018
@vthirumale
Copy link
Contributor Author

You are welcome. Thanks for accepting!

@rogerhu
Copy link

rogerhu commented Jan 9, 2019

Can you tag/release? This is a major bug that's forcing us to pin to older pipenvs..

@scottj97
Copy link

I also just hit this bug and wasted some time tracking it down. Why has there not been any new release of pipenv in almost 9 months?

@vthirumale
Copy link
Contributor Author

vthirumale commented Aug 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants