Ensure docs show nav on small-screen devices #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
approved these changes
Apr 2, 2019
|
Seems like a good idea to me, thanks for the PR and for your patience while we fix things :) |
|
Also thanks @dimaqq for the triage |
techalchemy
added
Status: Accepted ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
The sidebar (which is the bottom navigation) on mobile devices is hidden by a line of CSS. This prevents pages from being navigated on small-screen devices, as mentioned in #3527.
The fix
Removes the CSS line, which means the navigation gets shown again. Nav is responsive on small-screen devices care of the Alabaster base theme so there's no issue with showing it.
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.