Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document usage of Pipenv in multistage docker build #4918

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Document usage of Pipenv in multistage docker build #4918

merged 1 commit into from
Jan 12, 2022

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Jan 11, 2022

Following the discussion on #4917.
This PR add documentation which demonstrates how to use multistage build, and an explicit not on usage as root.
@jfly, @matteius, your feed back is appreciated!

@oz123
Document usage of Pipenv in multistage docker build
fa0452f 
Also, add a note about running Pipenv as root (or Admin)
with a bold warning.
@oz123 oz123 added Type: Documentation 📖 This issue relates to documentation of pipenv. Category: Docker Issue affects docker builds. labels Jan 11, 2022
jfly
jfly approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

matteius
matteius approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@matteius matteius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and now leverages the benefit of locked dependency hashes by using pipenv sync; thanks for doing this @oz123 !

@oz123 oz123 merged commit 9770d6e into main Jan 12, 2022
@oz123 oz123 deleted the multi-stage-build-with-pipenv branch January 12, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteius matteius matteius approved these changes

@jfly jfly jfly approved these changes

Assignees
No one assigned
Labels
Category: Docker Issue affects docker builds. Type: Documentation 📖 This issue relates to documentation of pipenv.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oz123 @jfly @matteius