Issue 4993 Add standard pre commit hooks and apply linting. #4994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rning to above its usage. * Move these utils from internet since they are shell related and remove rm_tree as it pipenv uses the version from vistir.
…). This does not include the MyPy linting that pip does but does include everything else.
… configuration to be able to commit this.
…ck of the project. Undoes backtick changes to vendor files.
matteius
force-pushed
the
issue-4993-pre-commit-hooks
branch
from
ae2711c to
9500e85
Compare
matteius
added
the
Status: Deferred / On Hold 🛑
|
Put on hold as it has to follow the merging of the split-utils branch, since its based off that. |
matteius
removed
the
Status: Deferred / On Hold 🛑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how pip has pre-commit configuration: https://github.com/pypa/pip/blob/main/.pre-commit-config.yaml
This adds the configuration, applies it using
pre-commit run --all-files --verboseand like usual there are a few flake8 things that had to be manually applied, but 99% of this was applied automatically by the linting tools. Also updates the .github action to have a component to check thepre-commit run --all-filesdoesn't have errors.TODO:
pre-commit installorpip install pre-commitif that is missing)The issue
#4993
The fix
Follows the standards of the pip project, but customized for excluding our vendor and patched directories. Updated to the latest package versions of the pre-commit hooks packages.
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.