Remove some more vistir usage #5067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed since Python version 3.6. Earlier versions didn't have json.JSONDecodeError and raised ValueError instead.
|
@matteius I've seen this error for MacOS Python3.10 happen already a few times (in the main branch too). No idea how to fix it, but it seems unrelated to the changes I proposed in the PR. |
|
@oz123 I don't see where it has happened on the main branch ... link to a failed action? |
matteius
reviewed
Apr 21, 2022
| @@ -2791,8 +2792,9 @@ def do_check( | |||
|
|
|||
|
|
|||
| def do_graph(project, bare=False, json=False, json_tree=False, reverse=False): | |||
| import json as jsonlib | |||
There was a problem hiding this comment.
Can we just import json at the top level now? I don't really see why to namespace it to jsonlib either.
matteius
reviewed
Apr 21, 2022
matteius
approved these changes
Apr 21, 2022
I re-ran just the one failed job and it succeeded. Looks like a 1-off GitHub data transfer failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json.JSONDecodeErroris Python 3.6+Should work, but we might have to revert this.