Drop crayons in exceptions.py #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all crayon color with appropriate `click.style` calls.
oz123
force-pushed
the
drop-crayons-in-exceptions
branch
from
e56ca9c to
f3bccf4
Compare
matteius
reviewed
Apr 24, 2022
matteius
approved these changes
Apr 24, 2022
fraser-langton
pushed a commit
to fraser-langton/pipenv
that referenced
this pull request
Apr 25, 2022
* Remove crayons usage from exceptions.py Replace all crayon color with appropriate `click.style` calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we should remove crayons in favor of
click.echoandclick.secho.clickhas a large user base and thus a better support across all major platform.This PR is a test balloon. If it is merged, it allows us to carefully test that no drastic UI changes have
been introduced, without completely removing crayons.
Once we completely removed crayons, it's easy to fix #5057.