Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More vistir drops makefile improvements #5102

Merged
merged 11 commits into from
May 17, 2022

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented May 12, 2022

Found more stuff we can drop, so we are getting near the end of vistir dependency.
Also, gave a bit of dusting off the the makefile.

oz123 added 11 commits May 12, 2022 18:56
Could be that for some users (especially on windows) this might
be a regression. However, taking this on a good faith that upstream
click is already much better.
pipenv supports only python3 now, and this exception is built-in
since 3+.
This is built-in since python3.4, we only support later
versions.
Built-in since Python3.
This is built-in in shutil of Python3.4+ and later.
We only support later versions.
Since Python3.4+ this is imported only from `collections.abc`.
Built-in since Python3.5. We only support later versions.
The built-in `virtualenv` module is called `venv`. Seems like this
Makefile hasn't been used in a while. I like dusting stuff ...
Everytime that we run the tests we create a temporary virtualenv.
This is nice for idempotency, but really a killer for SSDs on developers
machines.
I would recommend also to document the ramdisks target, since running
the tests in the ramdisk should be faster.
Developers can now run:

make tests RAMDISK=1

To automagically setup a RAM disk and run the tests there.
@oz123 oz123 requested a review from matteius May 12, 2022 18:45
@oz123 oz123 merged commit 114eb8f into main May 17, 2022
@oz123 oz123 deleted the more-vistir-drops-makefile-improvements branch May 17, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants