Refactor to support the NO_COLOR argument and deprecate PIPENV_COLORBLIND #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
oz123
requested changes
Jul 23, 2022
pipenv/environments.py
Outdated
| PIPENV_COLORBLIND = bool(os.environ.get("PIPENV_COLORBLIND")) | ||
| """If set, disable terminal colors. | ||
| NO_COLOR = False | ||
| if env_to_bool(os.getenv("NO_COLOR")) or env_to_bool(os.getenv("PIPENV_COLORBLIND")): |
There was a problem hiding this comment.
If we are going to refer to no-color.org, we should also adopt their convention.
NO_COLOR should be a non empty string:
Command-line software which adds ANSI color to its output by default should check for a NO_COLOR environment variable that, when present and not an empty string (regardless of its value), prevents the addition of ANSI color.
By using env_to_bool we deviate from this behavior. Personally, I think it's better to use explicit boolean string, but it's hard fixing the whole world. We should stick to non-empty string IMO.
pipenv/cli/command.py
Outdated
| from pipenv.utils.shell import style_no_color | ||
| from pipenv.vendor import click | ||
|
|
||
| click.original_style = click.style |
There was a problem hiding this comment.
Good to keep around click.style with click.original_style.
oz123
pushed a commit
that referenced
this pull request
Jul 25, 2022
…ables (#5185) * Refactor to support the NO_COLOR argument and deprecate PIPENV_COLORBIND variable. * Add news fragment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to make NO_COLOR work and deprecated PIPENV_COLORBLIND.
The issue
There was some issues with the prior monkey patch suggested approach: #5184
So I opened this PR instead.