fix bug when auto completing install and uninstall #5225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
#5214
This commit fixes the auto completing crash mentioned in the above command.
The fix
The bug is related to click and I have opened a corresponding issue in their github:
pallets/click#2336
The main problem is that expose_value=False when used for arguments breaks the autocomplete.
The best solution is to fix click and then vendor the new version. However "expose_value=False" doesn't do anything for us as far as I can see. So removing it or setting it to true is a viable option.
The checklist
news/
directory to describe this fix with the extension.bugfix
,.feature
,.behavior
,.doc
..vendor
. or.trivial
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.