Convert this test off pip-shims, it became flakey recently. #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
approved these changes
Aug 6, 2022
| @@ -273,9 +274,7 @@ def convert_deps_to_pip( | |||
| return dependencies | |||
|
|
|||
| # Write requirements.txt to tmp directory. | |||
| from pipenv.vendor.vistir.path import create_tracked_tempfile | |||
|
|
|||
| f = create_tracked_tempfile(suffix="-requirements.txt", delete=False) | |||
There was a problem hiding this comment.
You always get bonus points for removing usage of vistir :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
This test sporadically fails on some of the CI runs -- looking more closely, we can convert off a vistir usage and update this test to not use pip-shims. Hopefully this helps the CI not fail this test randomly.