Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise how we do the import patch to include only module pipenv. #5267

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

matteius
Copy link
Member

@matteius matteius commented Aug 16, 2022

Fixes #5265
Fixes #5264

This is a much cleaner approach than to avoid having all the local site-packages in the path and require --ignore-installed as a workaround. For reference this particular code works on Python 3.5+

Ref: https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly

@matteius matteius requested a review from oz123 August 16, 2022 22:10
@oz123 oz123 merged commit ea64995 into main Aug 17, 2022
@oz123 oz123 deleted the issue-5265 branch August 17, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants