Some docs cleanups #5825
Merged
Some docs cleanups #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `pypi.python.org` now redirects to `pypi.org`, so let's point folks towards that to save them the redirect. 2. Travis CI has struggled mightily ever since they were acquired by a PE firm. Most open source projects have moved away from them. 3. Update the python version in the example so it doesn't look quite so dated. 4. Use the `name` key for `sources` as that's now [required](#5370 (comment)).
|
Thanks Jeff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pypi.python.orgnow redirects topypi.org, so let's point folks towards that to save them the redirect.namekey forsourcesas that's now required.I didn't include a news fragment as I thought the changes were too trivial to list.
I also didn't take the time to regenerate the lockfiles after changing the
Pipfile... that means the hashes are going to be wrong, but for the purposes of docs I think that's fine... no human will notice, and if they do runpipenvagainst the example and are surprised by the outcome they're welcome to submit a PR fixing that too. But for now I think tis fine. Certainly this PR leaves things better then they were.