Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipfile: Add build and twine #5901

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Pipfile: Add build and twine #5901

merged 5 commits into from
Sep 1, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 31, 2023

Landing these two Python dependencies should make pull request #5836 easier to complete.

@kalebmckale Your review, please.

@matteius matteius merged commit 705919b into pypa:main Sep 1, 2023
@cclauss cclauss deleted the add-build branch September 1, 2023 06:43
@cclauss
Copy link
Contributor Author

cclauss commented Sep 2, 2023

Just some notes on how I did this on my M1 Mac with two terminal tabs open...

% brew install [email protected]

Error: [email protected] has been disabled because it is deprecated upstream!

% docker run --rm -it python:3.7 bash
---> Inside the docker container...

apt-get -qq update && apt-get install -y vim  # Or your favorite editor
git clone https://github.com/pypa/pipenv
cd pipenv
python3 -m venv .venv
source .venv/bin/activate
pip install --upgrade pip
pip install pipenv
vi Pipfile  # Add build and twine
pipenv update --clear
pipenv shell
    # Inside shell...
    pipenv update --clear && exit
git diff  # Verify the changes
pwd
# Do not `exit` until AFTER the modified files have been docker copied out of the container!!

In another terminal tab...
% docker ps

CONTAINER ID   IMAGE                                                  COMMAND ...
413378ea9275   python:3.7                                             "bash" ...

% docker cp 413378ea9275:/pipenv/Pipfil* .
The modified files are now in the current working directory of the macOS file system.

@kalebmckale
Copy link
Contributor

I mean on an actual computer, it’s not a problem. On iPad, it’s not so easy. I did end up getting Python 3.7 installed, but the file took hours to go through the locking process and still eventually failed for some undetermined reason. iSH, the app I use, still has quite a few limitations to it.

@cclauss
Copy link
Contributor Author

cclauss commented Sep 2, 2023

On iOS, I have been involved with these two apps but they are sort of prepackaged vs. iSH.

@kalebmckale
Copy link
Contributor

Again, it’s not an issue of development. I personally use Pyto and Carnets. But compiling new versions of Python or running applications like locking Pipfile, as far as I know, cannot be done inside these apps. They don’t provide much of an isolated testing environment. However, I do like the convenience of developing on my iPad. It just makes some things a bit more tedious, but I generally like helping and doing what I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants