Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected behavior of pipenv install --skip-lock #6225

Merged
merged 2 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/6225.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Corrected behavior of ``pipenv install --skip-lock`` after behavioral install refactor introduced regression. No Pipfile.lock is generated with this fix and installation of vcs no longer fails with revision missing error.
10 changes: 3 additions & 7 deletions pipenv/routines/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -630,15 +630,11 @@ def do_init(
packages=packages,
editable_packages=editable_packages,
)
# Write out the lockfile if it doesn't exist.
if not project.lockfile_exists:
# Write out the lockfile if it doesn't exist and skip_lock is False
if not project.lockfile_exists and not skip_lock:
# Unless we're in a virtualenv not managed by pipenv, abort if we're
# using the system's python.
if (
(system or allow_global)
and not (project.s.PIPENV_VIRTUALENV)
and skip_lock is False
):
if (system or allow_global) and not project.s.PIPENV_VIRTUALENV:
raise exceptions.PipenvOptionsError(
"--system",
"--system is intended to be used for Pipfile installation, "
Expand Down
Loading