Fix shell detection #6230
Merged
Fix shell detection #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
matteius
reviewed
Sep 1, 2024
matteius
reviewed
Sep 13, 2024
oz123
force-pushed
the
fix-shell-detection
branch
from
b4de965 to
6b4b8f3
Compare
csh needs to come before bash.
matteius
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a silly bug - with some major consequeces - in #6215.
First, I forgot to include brackets in
endswith. Second, I added a "/" as if the command should be/bin/bashor/usr/bin/bash, which in Windows will be '/'. This is actually not needed and detecting the shell based on the last word (the command) without the path, should be fine on all OSs.