Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct printing of errors #6335

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix: correct printing of errors #6335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c13ed
fix: correct printing of errors
oz123 Jan 9, 2025
69d2331
fix: disable printing resolver verbose
oz123 Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pipenv/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,6 @@ def main(argv=None):
os.environ["PYTHONUNBUFFERED"] = "1"
parsed = handle_parsed_args(parsed)
if not parsed.verbose:
print(parsed.verbose)
logging.getLogger("pipenv").setLevel(logging.WARN)
_main(
parsed.pre,
Expand Down
6 changes: 3 additions & 3 deletions pipenv/utils/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def resolve(self):
try:
results = resolver.resolve(self.constraints, check_supported_wheels=False)
except InstallationError as e:
raise ResolutionFailure(message=str(e))
raise ResolutionFailure(message=e)
else:
self.results = set(results.all_requirements)
self.resolved_tree.update(self.results)
Expand Down Expand Up @@ -765,9 +765,9 @@ def resolve(cmd, st, project):
out = c.stdout.read()
if returncode != 0:
st.console.print(environments.PIPENV_SPINNER_FAIL_TEXT.format("Locking Failed!"))
err.print(out.strip())
# err.print(out.strip())
if not is_verbose:
err.print(err)
err.print(errors)
raise RuntimeError("Failed to lock Pipfile.lock!")
if is_verbose:
err.print(out.strip())
Expand Down
Loading