Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests #509

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Fix CI tests #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0dc6f4
Install nox with pip arg --use-feature-2020-resolver.
itsayellow Sep 29, 2020
7351078
Lock ansible version to make test pass.
itsayellow Sep 29, 2020
f44ad91
Fix package_name.
itsayellow Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/on-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
python -m pip install wheel
python -m pip install regex
- name: Install native-venv version of nox
run: pip install git+https://github.com/cs01/nox.git@5ea70723e9e6#egg=nox
run: pip install --use-feature=2020-resolver git+https://github.com/cs01/nox.git@5ea70723e9e6#egg=nox
- name: Execute Tests
run: |
nox --non-interactive --session tests-${{ matrix.python-version }}
9 changes: 6 additions & 3 deletions tests/test_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import re
import sys
from unittest import mock

Expand Down Expand Up @@ -47,15 +48,17 @@ def test_install_easy_packages(capsys, pipx_temp_env, caplog, package):


@pytest.mark.parametrize(
"package", ["cloudtoken", "awscli", "ansible", "shell-functools"]
"package", ["cloudtoken", "awscli", "ansible==2.9.13", "shell-functools"]
)
def test_install_tricky_packages(capsys, pipx_temp_env, caplog, package):
if os.getenv("FAST"):
pytest.skip("skipping slow tests")
if sys.platform.startswith("win") and package == "ansible":
if sys.platform.startswith("win") and package == "ansible==2.9.13":
pytest.skip("Ansible is not installable on Windows")

install_package(capsys, pipx_temp_env, caplog, package)
install_package(
capsys, pipx_temp_env, caplog, package, re.sub(r"==.+$", "", package)
)


# TODO: Add git+... spec when git is in binpath of tests (Issue #303)
Expand Down