-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: what are the possible types for the default generated versions file? #527
Comments
i haven't speced that out actually - i believe an if typechecking can be included in the release that drops python < 3.6 |
This is asking about what could possibly go into |
For an example of a "good" Python 2 drop, see scikit-hep/boost-histogram@v0.13.0...v1.0.0 - changed 2K lines, enabled full type support instead of halfway type checking, and still ended up with fewer lines of code. :) (pyupgrade via pre-commit was a way to get a nice head start ;) ) |
@henryiii i was thinking of altering the template of the version file to be typed |
…-template fix #527: add type annotations for version file template
I'm adding
version.pyi
to one of my projects so that mypy doesn't complain when this is missing. But what are the possible types forversion_tuple
produced here? I'm using this, based on the two things I've seen so far:Are there any other lengths of tuple possible? (4, 6, etc)
(would have made this a Discussion if they were activated, as it doesn't require code changes, just a question).
The text was updated successfully, but these errors were encountered: