fix typing-extensions constraint and don't duplicate runtime deps #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `tool.hatch.build.require-runtime-dependencies` is set,
hatchling will include the runtime dependencies during the
get_requires_for_build_{wheel,sdist,editable} calls.
This avoids the need to keep the dependencies synced between two places.
I made a mistake when syncing `project.dependencies` and `build-system.requires`. It should've been `python_version < "3.8"` in both places. Fixes: 3b5e034
|
for now im closing this as the solution for setuptools seems non-obvious this is still relevant if we ever get the chance for a more complete hatch port when the dependeny loop can be resolved |
|
thanks for providing this solution, its indeed awesome and its a bummer we have to stay on plain setuptools for a while longer i'll definitively take it in once we get a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.