Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2724 Adds detection of Windows ARM64 build environments #2725

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

zooba
Copy link
Contributor

@zooba zooba commented Jul 9, 2021

Adds detection of Windows ARM64 build environments for cross-compilation.

Closes #2724

Pull Request Checklist

@zooba
Copy link
Contributor Author

zooba commented Jul 9, 2021

Personally I think this is trivial enough to get by without a test. Setting up the build environment that needs this is a bit of a mess, but without this fix upstream it's worse because you need to force a patched setuptools into pip's isolated environments.

@jaraco
Copy link
Member

jaraco commented Jul 15, 2021

This change looks fine, except changes to _distutils should be applied to pypa/distutils. Let me see if I can grab the commit and merge it in here.

@jaraco
Copy link
Member

jaraco commented Jul 15, 2021

Pushed as pypa/distutils@f15f814e9e.

@jaraco jaraco merged commit 9487d9c into pypa:main Jul 15, 2021
@jaraco
Copy link
Member

jaraco commented Jul 15, 2021

Released as 57.2.0. Thanks!

@zooba zooba deleted the arm64 branch July 15, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] win-arm64 platform is not detected
2 participants