[CI] Fix codecov config #3053
Merged
[CI] Fix codecov config #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous `.codecov.yml` file had an invalid configuration: ```bash $ curl --data-binary @.codecov.yml https://codecov.io/validate Error at ['coverage', 'status', 'project', 'threshold']: must be of ['dict', 'boolean'] type ``` According to the [documentation](https://docs.codecov.com/docs/commit-status#section-project-status), `coverage.status.project` does not seem to accept configuration parameters directly. Instead it requires a mapping between project names (or `"default"` when all the projects are target) and the configuration parameters. This change fixes that by introducing a new nesting level with the `default` key between `project` and `default`. This passes the validation: ```bash % curl --data-binary @.codecov.yml https://codecov.io/validate Valid! { "comment": false, "coverage": { "status": { "project": { "default": { "threshold": 0.5 } } } } } ```
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The previous
.codecov.ymlfile had an invalid configuration:Summary of changes
According to the documentation,
coverage.status.projectdoes not seem to accept configuration parameters directly. Instead it requires a mapping between project names (or"default"when all the projects are targeted) and the configuration parameters.This change fixes that by introducing a new nesting level with the
defaultkey betweenprojectanddefault. This passes the validation:Closes
Pull Request Checklist
changelog.d/.(See documentation for details)