Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --force-reinstall in integration test and skip wheel #4565

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

abravalheri
Copy link
Contributor

Summary of changes

In integration test:

  • Replace pip install -I with pip install --force-reinstall
  • Do not install wheel as it is no longer a build dependency (it also no longer gets automatically installed in the build env in regular workflows).

Closes #4564

Pull Request Checklist

@abravalheri abravalheri changed the title Use --force-reinstall in integration test and skip wheel Use --force-reinstall in integration test and skip wheel Aug 13, 2024
@abravalheri
Copy link
Contributor Author

Integration tests should run in https://github.com/pypa/setuptools/actions/runs/10369805360, so we can see if this fixes the problem or not.

@abravalheri
Copy link
Contributor Author

Integration tests pass after the changes: https://github.com/pypa/setuptools/actions/runs/10369805360/job/28707136245.

@abravalheri abravalheri marked this pull request as ready for review August 13, 2024 14:24
@abravalheri abravalheri merged commit 6fcce38 into main Aug 13, 2024
34 of 55 checks passed
@abravalheri abravalheri deleted the fix-integration-test branch August 13, 2024 14:25
@jaraco
Copy link
Member

jaraco commented Aug 13, 2024

I re-ran the failed jobs for v72.2.0, since the release didn't go out as planned, and it succeeded.

@jaraco
Copy link
Member

jaraco commented Aug 13, 2024

Because the issue is intermittent, we'll want to keep an eye out to see if it happens again. Presumably this change will fix the issue. Thanks for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests for brotli are failing
2 participants