Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twine have indirect Python 2 only dependency. #241

Closed
Carreau opened this issue Apr 27, 2017 · 3 comments
Closed

Twine have indirect Python 2 only dependency. #241

Carreau opened this issue Apr 27, 2017 · 3 comments

Comments

@Carreau
Copy link
Contributor

Carreau commented Apr 27, 2017

Twine rely on clint which install args, which AFAICT has no published Python 3 compatible versions:

  File "/root/miniconda3/lib/python3.6/site-packages/args.py", line 394, in <module>
    flags = args.flags
  File "/root/miniconda3/lib/python3.6/site-packages/args.py", line 328, in flags
    return self.start_with('-')
  File "/root/miniconda3/lib/python3.6/site-packages/args.py", line 192, in start_with
    if _is_collection(x):
  File "/root/miniconda3/lib/python3.6/site-packages/args.py", line 37, in _is_collection
    if isinstance(obj, basestring):
NameError: name 'basestring' is not defined

Which has the side effect of breaking as soon as sphinx autolink kick in and try to figure out what blah blah `args` blah blah could mean as it import args. (numpy/numpy#9005)

It would be nice to have twine be completely Python 3 compatible.

The activity on Clint and Args make me doubt I'll get a response though, so opening issue here.

@di
Copy link
Member

di commented Apr 27, 2017

It seems like clint is only being used to generate a progress bar. Perhaps we could use tqdm (which is active and supports Python 3) instead?

@sigmavirus24
Copy link
Member

I'd merge a pull request that switches us over to tqdm. Thanks for pointing this out @Carreau. :)

Carreau added a commit to Carreau/twine that referenced this issue Apr 27, 2017
Closes pypa#241 – As clint as some indirect Python 2 dependency and tqdm has
not.
Carreau added a commit to Carreau/twine that referenced this issue Apr 27, 2017
Closes pypa#241 – As clint as some indirect Python 2 dependency and tqdm has
not.
@Carreau
Copy link
Contributor Author

Carreau commented Apr 27, 2017

I'd merge a pull request that switches us over to tqdm.

See #242.

Thanks for pointing this out @Carreau. :)

Thanks to you for maintaining twine, and being responsive !

Carreau added a commit to Carreau/twine that referenced this issue Apr 29, 2017
Closes pypa#241 – As clint as some indirect Python 2 dependency and tqdm has
not.
Carreau added a commit to Carreau/twine that referenced this issue May 1, 2017
Closes pypa#241 – As clint as some indirect Python 2 dependency and tqdm has
not.
Carreau added a commit to Carreau/twine that referenced this issue May 2, 2017
Closes pypa#241 – As clint as some indirect Python 2 dependency and tqdm has
not.
Carreau added a commit to Carreau/twine that referenced this issue May 2, 2017
Closes pypa#241 – As clint as some indirect Python 2 dependency and tqdm has
not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants