Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and tweak tqdm progressbar #256

Merged
merged 1 commit into from
May 29, 2017
Merged

update and tweak tqdm progressbar #256

merged 1 commit into from
May 29, 2017

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented May 29, 2017

This is a follow-on from #242.

  • update to latest version of tqdm>=4.14
    • use unit_divisor=1024 instead of 1000
  • use 'B' as units instead of 'bytes'
  • leave progressbar upon completion (to match old behaviour when clint was used, and to look pretty and provide permanent info)

external:

  • ensure users can download tqdm>=4.14 via:
    • pypi
    • conda

thanks for using tqdm!

-- thanks for using tqdm!
@codecov-io
Copy link

codecov-io commented May 29, 2017

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   67.01%   67.01%           
=======================================
  Files          12       12           
  Lines         573      573           
  Branches       91       91           
=======================================
  Hits          384      384           
  Misses        162      162           
  Partials       27       27
Impacted Files Coverage Δ
twine/repository.py 59.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f1505...3b76685. Read the comment docs.

@casperdcl
Copy link
Contributor Author

looks good to merge

@sigmavirus24
Copy link
Member

Thanks @casperdcl!

@sigmavirus24 sigmavirus24 merged commit 04cd2ff into pypa:master May 29, 2017
@casperdcl casperdcl deleted the tqdm-update branch May 29, 2017 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants