virtualenv doesn't notice when installing distribute fails

[hukka]

Trying to create a new virtualenv outputs

New python executable in my_new_env3.2/bin/python3.2
Also creating executable in my_new_env3.2/bin/python
Installing distribute......................................................................................................done.
Installing pip....
  Complete output from command /home/tpievila/work/...env3.2/bin/python3.2 -x /home/tpievila/work/...3.2/bin/easy_install pip:
  /home/tpievila/work/pas/my_new_env3.2/bin/python3.2: can't open file '/home/tpievila/work/pas/my_new_env3.2/bin/easy_install': [Errno 2] No such file or directory
----------------------------------------
...Installing pip...done.
Traceback (most recent call last):
  File "virtualenv.py", line 2429, in <module>
    main()
  File "virtualenv.py", line 942, in main
    never_download=options.never_download)
  File "virtualenv.py", line 1054, in create_environment
    install_pip(py_executable, search_dirs=search_dirs, never_download=never_download)
  File "virtualenv.py", line 654, in install_pip
    filter_stdout=_filter_setup)
  File "virtualenv.py", line 1020, in call_subprocess
    % (cmd_desc, proc.returncode))
OSError: Command /home/tpievila/work/...env3.2/bin/python3.2 -x /home/tpievila/work/...3.2/bin/easy_install pip failed with error code 2

Only when -vvv is activated, the output shows (irrelevant parts snipped):

Traceback (most recent call last):
    File "setup.py", line 25, in <module>
      from lib2to3.main import main
    File "/usr/local/lib/python3.2/lib2to3/main.py", line 14, in <module>
      from . import refactor
    File "/usr/local/lib/python3.2/lib2to3/refactor.py", line 27, in <module>
      from .fixer_util import find_root
    File "/usr/local/lib/python3.2/lib2to3/fixer_util.py", line 9, in <module>
      from .pygram import python_symbols as syms
    File "/usr/local/lib/python3.2/lib2to3/pygram.py", line 32, in <module>
      python_grammar = driver.load_grammar(_GRAMMAR_FILE)
    File "/usr/local/lib/python3.2/lib2to3/pgen2/driver.py", line 130, in load_grammar
      g.load(gp)
    File "/usr/local/lib/python3.2/lib2to3/pgen2/grammar.py", line 95, in load
      f = open(filename, "rb")
  IOError: [Errno 13] Permission denied: '/usr/local/lib/python3.2/lib2to3/Grammar3.2.3.final.0.pickle'
  Something went wrong during the installation.
  See the error message above.
...Installing distribute...done.

so actually distribute install is NOT done. Virtualenv should notice this and abort the installation at that point, reducing time to debug the situation.

[carljm]

Yes, certainly - pull request welcome.

[g2p]

I have a local fix to virtualenv_embedded/distribute_setup.py , but I've sent it to distribute first since it's the upstream for that file: https://bitbucket.org/tarek/distribute/pull-request/23/

Once distribute is updated, it will be a matter of running bin/refresh-support-files.py and bin/rebuild-script.py to update virtualenv.

[g2p]

So, it's been merged in the development version of distribute. I don't know about their release timeline.

[stefanholek]

FYI, distribute 0.6.29 has been released including your fix.