Improve executable discovery of a PythonInfo inside a given folder #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saytosid
commented
Nov 14, 2019
•
saytosid
commented
- Use architecture, version, implementation and platform extensions for candidates
- Cache PythonInfo.from_exe by path (resolving symlinks)
- Ensure what we discover has the same version, implementation and architecture.
- Improve our test suite for this functionality.
gaborbernat
requested changes
Nov 15, 2019
gaborbernat
force-pushed
the
rewrite
branch
2 times, most recently
from
9c2ae47 to
91d5cb1
Compare
gaborbernat
force-pushed
the
rewrite
branch
12 times, most recently
from
5447ee5 to
f2fc080
Compare
…r folder. - Use architecture, version, implementation and platform extensions for candiates - Cache PythonInfo.from_exe by path (resolving symlinks) - Ensure what we discover has the same version, implementation and architecture. - Improve our test suite for this functionality. Signed-off-by: Bernat Gabor <[email protected]>
gaborbernat
force-pushed
the
fix-executable-discovery
branch
from
2830139 to
6b55a4d
Compare
gaborbernat
changed the title
python or python.exe
gaborbernat
pushed a commit
that referenced
this pull request
Dec 15, 2019
- Use architecture, version, implementation and platform extensions for candiates - Cache PythonInfo.from_exe by path (resolving symlinks) - Ensure what we discover has the same version, implementation and architecture. - Improve our test suite for this functionality. Signed-off-by: Bernat Gabor <[email protected]>
gaborbernat
pushed a commit
that referenced
this pull request
Dec 18, 2019
- Use architecture, version, implementation and platform extensions for candiates - Cache PythonInfo.from_exe by path (resolving symlinks) - Ensure what we discover has the same version, implementation and architecture. - Improve our test suite for this functionality. Signed-off-by: Bernat Gabor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.