Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activation scripts for next-gen virtualenv #1454

Merged
merged 15 commits into from
Dec 15, 2019

Conversation

saytosid
Copy link
Contributor

Activators for various activation scripts

Thanks for contributing a pull request, see checklist all is good!

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added news fragment in docs/changelog folder

Signed-off-by: Bernat Gabor <[email protected]>
@gaborbernat gaborbernat force-pushed the activation-scripts branch 2 times, most recently from 5a54c43 to 1809bf7 Compare November 29, 2019 18:50
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
@saytosid saytosid force-pushed the activation-scripts branch 2 times, most recently from ce9949d to dc436a8 Compare December 1, 2019 09:23
@gaborbernat gaborbernat changed the title [WIP] Activation scripts; some tests remain Activation scripts for next-gen virtualenv Dec 15, 2019
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now done.

thanks

PS. @saytosid One thing that's still missing is tests for the python activator, but let's add it a follow-up PR, if you have time anytime soon.

@gaborbernat gaborbernat merged commit e10edc7 into pypa:rewrite Dec 15, 2019
@saytosid saytosid deleted the activation-scripts branch March 6, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants