Restore unintentionally-modified pre-2186 cleanup behaviors
#2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Do not disturb platdir 2. Do delete a target directory on install if it is present and wasn't a part of the distro that could've been uninstalled fixes pypa#2198
gaborbernat
requested changes
Sep 25, 2021
Comment on lines
+154
to
+155
| # Only uninstall purelib as it's the only one that VirtualEnv installs into | ||
| in_folders = chain.from_iterable([i.iterdir() for i in {self._creator.purelib}]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasn't a part of the distro that could've been uninstalled
fixes #2198
Thanks for contributing, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint)docs/changelogfolder