Fix assert error when virtual path shares a common prefix with real path #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this area of code changed a bit with another recently-merged PR, mind rebasing or merging from develop so this merges cleanly? Thanks! |
…ath. If (real) Python is installed at (say) `/opt/python2.7.3` and you have a virtualenv at `/opt/python`, `change_prefix()` will try to split off `/opt/python` from a path like `/opt/python2.7.3/lib/python2.7/distutils`, leaving `2.7.3/lib/python2.7/distutils`, which is not valid and fails the assert. This patch sorts the list of prefixes by length, so the longer path is tried before its prefix.
|
I've rebased my patch. Sorry about the delay; the other updates in between actually fixed the specific instance of my problem, but this will hopefully keep others from running into it. |
pnasrat
added a commit
that referenced
this pull request
Oct 19, 2012
Fix assert error when virtual path shares a common prefix with real path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If (real) Python is installed at (say)
/opt/python2.7.3and you have avirtualenv at
/opt/python,change_prefix()will try to split off/opt/pythonfrom a path like/opt/python2.7.3/lib/python2.7/distutils,leaving
2.7.3/lib/python2.7/distutils, which is not valid and failsthe assert.
This patch sorts the list of prefixes by length, so the longer path is
tried before its prefix.